feat: ensure MLS is established when joining meeting [WPB-25677] - #5114
Open
saleniuk wants to merge 6 commits into
Open
feat: ensure MLS is established when joining meeting [WPB-25677]#5114saleniuk wants to merge 6 commits into
saleniuk wants to merge 6 commits into
Conversation
saleniuk
changed the title
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #5114 +/- ##
===========================================
+ Coverage 50.15% 50.27% +0.11%
===========================================
Files 666 666
Lines 24397 24413 +16
Branches 3780 3781 +1
===========================================
+ Hits 12237 12273 +36
+ Misses 11039 11019 -20
Partials 1121 1121
Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
Contributor
Contributor
|
APKs built during tests are available here. Scroll down to Artifacts! |
…tablished-for-meeting # Conflicts: # app/src/main/kotlin/com/wire/android/di/accountScoped/MeetingModule.kt # features/meetings/src/main/res/values/strings.xml
Contributor
|
APKs built during tests are available here. Scroll down to Artifacts! |
…tablished-for-meeting
Contributor
|
APKs built during tests are available here. Scroll down to Artifacts! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://wearezeta.atlassian.net/browse/WPB-25677
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764The PR Description
What's new in this PR?
Logic for making sure that the meeting's underlying MLS conversation has already established MLS group.
Dependencies (Optional)
Needs releases with:
Testing
Test Coverage (Optional)
How to Test
Open dev-debug build, go to "meetings" tab, you need to have a meeting with a conversation that doesn't have MLS group established yet and try to join that meeting when it's ongoing.
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.